appFavorites: Fix nonsense condition

The "in" operator has a lower precedence than negation, so we are
actually testing whether the favorites map contains "false".

Add parentheses to get the intended behavior.

Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/375

diff --git a/js/ui/appFavorites.js b/js/ui/appFavorites.js
index 0bdf41b22e82d74a2b70ba2c33ff4bfcbc66ca0c..cc3e3c32ae7b13c5ece1be8572da498ef53e7d0f 100644 (file)
--- a/js/ui/appFavorites.js
+++ b/js/ui/appFavorites.js
@@ -153,7 +153,7 @@ class AppFavorites {
     }
 
     _removeFavorite(appId) {
-        if (!appId in this._favorites)
+        if (!(appId in this._favorites))
             return false;
 
         let ids = this._getIds().filter(id => id != appId);